Skip to content

styles: chat scroll interaction #1837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nahiyankhan merged 3 commits into from
Mar 25, 2025
Merged

styles: chat scroll interaction #1837

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd6aa93
scroll visual tweak
nahiyankhan Mar 7, 2025
3aab995
reset
nahiyankhan Mar 24, 2025
009056c
tweaks
nahiyankhan Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ui/desktop/src/components/ui/scroll-area.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ const ScrollArea = React.forwardRef<ScrollAreaHandle, ScrollAreaProps>(
const viewportRef = React.useRef<HTMLDivElement>(null);
const viewportEndRef = React.useRef<HTMLDivElement>(null);
const [isFollowing, setIsFollowing] = React.useState(true);
const [isScrolled, setIsScrolled] = React.useState(false);

const scrollToBottom = React.useCallback(() => {
if (viewportEndRef.current) {
Expand Down Expand Up @@ -48,6 +49,9 @@ const ScrollArea = React.forwardRef<ScrollAreaHandle, ScrollAreaProps>(
const scrollBottom = scrollTop + clientHeight;
const newIsFollowing = scrollHeight === scrollBottom;

// Check if scrolled from top
setIsScrolled(scrollTop > 0);

// react will internally optimize this to not re-store the same values
setIsFollowing(newIsFollowing);
}, []);
Expand All @@ -71,8 +75,15 @@ const ScrollArea = React.forwardRef<ScrollAreaHandle, ScrollAreaProps>(
<ScrollAreaPrimitive.Root
ref={rootRef}
className={cn('relative overflow-hidden', className)}
data-scrolled={isScrolled}
{...props}
>
<div
className={cn(
'absolute top-0 left-0 right-0 z-10 transition-all duration-200',
isScrolled ? 'border-t border-borderSubtle' : 'border-t border-transparent'
)}
/>
<ScrollAreaPrimitive.Viewport
ref={viewportRef}
className="h-full w-full rounded-[inherit] [&>div]:!block"
Expand Down