Skip to content

fix(cli): multiselect visibility for light themes #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wendytang merged 1 commit into from
Mar 24, 2025
Merged

fix(cli): multiselect visibility for light themes #1716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions crates/goose-cli/src/commands/configure.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ use serde_json::{json, Value};
use std::collections::HashMap;
use std::error::Error;

// useful for light themes where there is no dicernible colour contrast between
// cursor-selected and cursor-unselected items.
const MULTISELECT_VISIBILITY_HINT: &str = "<";

fn get_display_name(extension_id: &str) -> String {
match extension_id {
"developer" => "Developer Tools".to_string(),
Expand Down Expand Up @@ -408,7 +412,7 @@ pub fn toggle_extensions_dialog() -> Result<(), Box<dyn Error>> {
.items(
&extension_status
.iter()
.map(|(name, _)| (name, name.as_str(), ""))
.map(|(name, _)| (name, name.as_str(), MULTISELECT_VISIBILITY_HINT))
.collect::<Vec<_>>(),
)
.initial_values(enabled_extensions)
Expand Down Expand Up @@ -719,7 +723,7 @@ pub fn remove_extension_dialog() -> Result<(), Box<dyn Error>> {
&disabled_extensions
.iter()
.filter(|(_, enabled)| !enabled)
.map(|(name, _)| (name, name.as_str(), ""))
.map(|(name, _)| (name, name.as_str(), MULTISELECT_VISIBILITY_HINT))
.collect::<Vec<_>>(),
)
.interact()?;
Expand Down Expand Up @@ -872,7 +876,7 @@ pub fn toggle_experiments_dialog() -> Result<(), Box<dyn Error>> {
.items(
&experiments
.iter()
.map(|(name, _)| (name, name.as_str(), ""))
.map(|(name, _)| (name, name.as_str(), MULTISELECT_VISIBILITY_HINT))
.collect::<Vec<_>>(),
)
.initial_values(enabled_experiments)
Expand Down