chore: make vcr tests pretty-print JSON#146
Merged
Merged
Conversation
Signed-off-by: Adrian Cole <adrian.cole@elastic.co>
anuraaga
approved these changes
Oct 13, 2024
| pass | ||
|
|
||
|
|
||
| def literal_presenter(dumper, data): |
There was a problem hiding this comment.
Maybe a comment on what this does. IIUC it forces mutliline string
Collaborator
Author
There was a problem hiding this comment.
thanks for the feedback, I changed the function name and put some comments on it. hope it is better!
Signed-off-by: Adrian Cole <adrian.cole@elastic.co>
michaelneale
approved these changes
Oct 13, 2024
Collaborator
|
looks tidy |
Contributor
|
@codefromthecrypt this is so much cleaner! very slick approach |
lamchau
approved these changes
Oct 15, 2024
Collaborator
Author
|
thanks for the look, folks |
ahau-square
pushed a commit
that referenced
this pull request
Oct 16, 2024
* origin/main: docs: add subheaders to the 'Other ways to run Goose' section (#155) fix: Remove tools from exchange when summarizing files (#157) chore: use primitives instead of typing imports and fixes completion … (#149) chore: make vcr tests pretty-print JSON (#146) chore(release): goose 0.9.5 (#159) chore(release): exchange 0.9.5 (#158)
lukealvoeiro
added a commit
that referenced
this pull request
Oct 17, 2024
* main: (23 commits) feat: Run with resume session (#153) refactor: move langfuse wrapper to a module in exchange instead of a package (#138) docs: add subheaders to the 'Other ways to run Goose' section (#155) fix: Remove tools from exchange when summarizing files (#157) chore: use primitives instead of typing imports and fixes completion … (#149) chore: make vcr tests pretty-print JSON (#146) chore(release): goose 0.9.5 (#159) chore(release): exchange 0.9.5 (#158) chore: updates ollama default model from mistral-nemo to qwen2.5 (#150) feat: add vision support for Google (#141) fix: session resume with arg handled incorrectly (#145) docs: add release instructions to CONTRIBUTING.md (#143) docs: add link to action, IDE words (#140) docs: goosehints doc fix only (#142) chore(release): release 0.9.4 (#136) revert: "feat: add local langfuse tracing option (#106)" (#137) feat: add local langfuse tracing option (#106) feat: add groq provider (#134) feat: add a deep thinking reasoner model (o1-preview/mini) (#68) fix: use concrete SessionNotifier (#135) ...
11 tasks
ahau-square
pushed a commit
that referenced
this pull request
May 2, 2025
Signed-off-by: Adrian Cole <adrian.cole@elastic.co>
cbruyndoncx
pushed a commit
to cbruyndoncx/goose
that referenced
this pull request
Jul 20, 2025
Signed-off-by: Adrian Cole <adrian.cole@elastic.co>
jamadeo
pushed a commit
that referenced
this pull request
Apr 13, 2026
* feat: add Cmd/Ctrl+N shortcut to open new conversation screen Adds a keyboard shortcut (Cmd+N on macOS, Ctrl+N on Windows/Linux) that navigates to the home screen for starting a new conversation. Cleans up any empty draft session before navigating. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: Cmd/Ctrl+N should open new conversation, not home screen Use createNewTab() so the shortcut creates a draft chat session showing the "Start a conversation" empty state, matching the sidebar's new chat behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix: use Cmd+N only, matching other shortcuts in the handler Remove Ctrl+N support to stay consistent with the other keyboard shortcuts (Cmd+,, Cmd+B, Cmd+W) which only check metaKey. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes recordings of HTTP requests and responses more readable at the cost of a little more code.
cc @lamchau @anuraaga as I'm still learning python, so possibly my approach isn't ideal. Changes welcome!
Fixes #127