Skip to content

fix(summon): reuse parent provider for delegates - #10754

Merged
alexhancock merged 1 commit into
aaif-goose:mainfrom
AnthonyRonning:fix/summon-provider-inheritance
Jul 29, 2026
Merged

fix(summon): reuse parent provider for delegates#10754
alexhancock merged 1 commit into
aaif-goose:mainfrom
AnthonyRonning:fix/summon-provider-inheritance

Conversation

@AnthonyRonning

Copy link
Copy Markdown
Contributor

Summary

  • reuse the parent Agent's installed provider when a Summon delegate resolves to the same provider
  • keep registry construction for different providers and providers that manage their own context
  • add regression coverage for an injected provider

Testing

  • cargo test -p goose agents::platform_extensions::summon::tests --lib
  • cargo clippy -p goose --lib -- -D warnings
  • cargo fmt --all -- --check

Fixes #10753

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bff7007202

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread crates/goose/src/agents/platform_extensions/summon.rs Outdated
@AnthonyRonning
AnthonyRonning force-pushed the fix/summon-provider-inheritance branch from bff7007 to 7698d23 Compare July 28, 2026 03:53

@michaelneale michaelneale left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - I think it makes sense

@alexhancock
alexhancock merged commit 9fec415 into aaif-goose:main Jul 29, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Summon discards the active provider when delegating

3 participants