Skip to content

fix: stop resolving TUI scripts from cwd - #10449

Merged
alexhancock merged 2 commits into
mainfrom
jbg/security-tui-cwd-script
Jul 14, 2026
Merged

fix: stop resolving TUI scripts from cwd#10449
alexhancock merged 2 commits into
mainfrom
jbg/security-tui-cwd-script

Conversation

@jbg

@jbg jbg commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Stop resolving the text UI entry point from the process working directory.

Local development discovery remains anchored to the Goose executable, with the existing npm fallback unchanged. Regression coverage verifies that working-directory content is ignored and executable-ancestor discovery still works.

Tests:

  • cargo test -p goose-cli --features tui commands::tui::tests
  • cargo build -p goose-cli --features tui
  • cargo clippy -p goose-cli --all-targets --features tui -- -D warnings
  • cargo fmt --all

This finding was discovered by Project Loupe.

@jbg
jbg requested a review from alexhancock July 14, 2026 10:54
@jbg
jbg marked this pull request as ready for review July 14, 2026 10:54

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b2fd411552

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/goose-cli/src/commands/tui.rs Outdated
@jbg
jbg requested a review from DOsinga July 14, 2026 11:30
@alexhancock
alexhancock added this pull request to the merge queue Jul 14, 2026
Merged via the queue into main with commit 846c764 Jul 14, 2026
24 checks passed
@alexhancock
alexhancock deleted the jbg/security-tui-cwd-script branch July 14, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants