fix: updated spin to v0.9.9 as 0.9.8 is yanked - #10445
Merged
Merged
Conversation
lifeizhou-ap
enabled auto-merge
July 14, 2026 07:32
michaelneale
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix crate deny
https://github.com/aaif-goose/goose/actions/runs/29312777755/job/87020007313
After triggering the
v1.43.0release, I noticed that Cargo Deny failed because the release includes the recently yankedspin 0.9.8.The version was yanked because of an issue affecting specific spin::Once methods that consume or drop their stored value. A yank does not remove the crate or prevent projects with an existing Cargo.lock from building.
In Goose, spin is only a transitive dependency:
goose → sqlx → sqlx-sqlite → flume → spin
It also appears through lazy_static in other transitive paths. Goose does not call spin directly. flume uses its mutex functionality, while lazy_static uses Once only for static initialization, so these paths do not appear to exercise the affected behavior. In addition, we have used this version
0.9.8for long time.So v1.43.0 has low practical risk and does not require an emergency patch or recall. The upgrade to spin 0.9.9 is in this PR and will be included in next week’s release.