feat(providers): Add Cerebras Reasoning Support by aaalaniz · Pull Request #10417 · aaif-goose/goose

aaalaniz · 2026-07-13T12:33:35Z

This PR introduces flexible reasoning support for providers that use non-standard parameters, starting with Cerebras.

It adds a new ReasoningConfig that lets models declare:

Which property name to use for reasoning in requests
How to map reasoning effort levels (low / medium / high) to provider-specific values via effort_mapping
Optional extra_body JSON that gets merged into the request when reasoning is enabled

The primary goal was to unblock reliable multi-turn usage with Cerebras models. The design is intentionally provider-agnostic so future models can adapt requests to their specific requirements without changing core logic.

flowchart TD
    A[Model declares ReasoningConfig] --> B{Reasoning enabled?}
    B -->|No| C[Omit reasoning params]
    B -->|Yes| D[Apply effort_mapping]
    D --> E[Merge extra_body if present]
    E --> F[Send request to provider<br/>e.g. Cerebras]
    F --> G[Receive response with thinking]
    G --> H[Apply ThinkingPreservationFormat<br/>to message history]

Problem

Prior to this change, any multi-turn conversation with a Cerebras model that had thinking/reasoning enabled would fail with:

Before

before-400.mov

After

after.mp4

Fixes #10406

aaalaniz · 2026-07-13T13:31:44Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e2d2001b0f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

aaalaniz · 2026-07-13T17:25:15Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1031a98f33

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

aaalaniz · 2026-07-13T21:20:00Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 76ff9b932f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

aaalaniz · 2026-07-14T00:39:15Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 93ec063c04

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

aaalaniz · 2026-07-14T01:32:30Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 899c346e35

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

aaalaniz · 2026-07-14T01:51:53Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9b89e25a80

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

aaalaniz · 2026-07-14T02:06:27Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3b46d13ced

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

aaalaniz · 2026-07-14T02:26:25Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a73529d933

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

aaalaniz · 2026-07-14T09:50:25Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 615d519249

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

aaalaniz · 2026-07-14T10:03:10Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d37097fe79

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

aaalaniz · 2026-07-14T11:09:41Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 64084b8aca

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

aaalaniz · 2026-07-14T11:26:33Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c48266945b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

aaalaniz · 2026-07-14T11:40:45Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7f0087e2c0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

aaalaniz · 2026-07-14T13:34:24Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e46c224c50

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

aaalaniz · 2026-07-14T13:59:04Z

@codex review

chatgpt-codex-connector · 2026-07-14T14:08:26Z

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: ef3030cd03

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

… metadata

…ers for non-OpenAI models

… to none

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 975c5fc9c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Resolves conflicts with the uniffi API layer change (aaif-goose#10427), which added `ModelConfig::request_headers` alongside this branch's `reasoning: Option<Reasoning>` / `reasoning_is_explicit` fields. Both sides are kept in `ModelConfig`, its `Deserialize` impl, `ModelConfig::new`, and the uniffi `ProviderModelConfig` conversion, where `with_reasoning` now runs after `with_request_headers`. Also adapts two tests added upstream to the new `Reasoning` enum and the `reasoning_is_explicit` field. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 81d9fbbb0b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-07-27T01:57:49Z

+      "reasoning": {
+        "enabled": true,
+        "thinking_preservation_format": "content_prepend",


Add reasoning coverage to the self-test recipe

This introduces provider-specific reasoning payload and history-preservation behavior, but the commit does not update goose-self-test.yaml, leaving the required end-to-end recipe validation for the new feature absent. Add a self-test case that exercises the Cerebras reasoning configuration and replay format.

AGENTS.md reference: AGENTS.md:L71-L71

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-07-27T01:57:49Z

+        };
+        model_config.reasoning = Some(crate::base::Reasoning::ReasoningConfig(reasoning));
+
+        // Use `true` for streaming


Remove self-evident test narration

This comment only restates the literal true streaming argument, and the nearby comment similarly narrates the assertion rather than explaining non-obvious behavior. Remove these comments so the tests comply with the repository's explicit prohibition on comments for self-evident operations.

AGENTS.md reference: AGENTS.md:L112-L112

Useful? React with 👍 / 👎.

filipkujawa · 2026-07-27T19:23:17Z

Hey @aaalaniz, thanks for the PR! I reviewed and tested this in depth, and discussed with team:

The core fix is real and verified. I reproduced the bug E2E on main, with your branch the same session works with the reasoning correctly re-embedded into content, exactly as the Cerebras docs require. Your thinking_preservation_format design is the right shape for this.

My ask: split the PR so we can land that fix now

Part A (this PR but trimmed): thinking preservation + the typed reasoning format, scoped to OpenAI-compatible providers, plus the cerebras.json refresh. This unblocks Cerebras reasoning users

Part B (defer): the generalized reasoning config (Reasoning enum, effort_mapping, extra_body, reasoning_is_explicit). There are a few issues that came up with it in testing and the team has ideas for a unified reasoning design that we'd like to flesh out to get this design right.

aaalaniz · 2026-07-27T19:53:35Z

Hey @aaalaniz, thanks for the PR! I reviewed and tested this in depth, and discussed with team:

The core fix is real and verified. I reproduced the bug E2E on main, with your branch the same session works with the reasoning correctly re-embedded into content, exactly as the Cerebras docs require. Your thinking_preservation_format design is the right shape for this.

My ask: split the PR so we can land that fix now

Part A (this PR but trimmed): thinking preservation + the typed reasoning format, scoped to OpenAI-compatible providers, plus the cerebras.json refresh. This unblocks Cerebras reasoning users

Part B (defer): the generalized reasoning config (Reasoning enum, effort_mapping, extra_body, reasoning_is_explicit). There are a few issues that came up with it in testing and the team has ideas for a unified reasoning design that we'd like to flesh out to get this design right.

Agreed, and great feedback. Will do!

chatgpt-codex-connector Bot reviewed Jul 13, 2026

View reviewed changes

Comment thread crates/goose-provider-types/src/formats/openai.rs Outdated

Comment thread crates/goose-providers/src/openai.rs Outdated

chatgpt-codex-connector Bot reviewed Jul 13, 2026

View reviewed changes

Comment thread crates/goose-providers/src/openai.rs Outdated

chatgpt-codex-connector Bot reviewed Jul 13, 2026

View reviewed changes

Comment thread crates/goose-providers/src/openai.rs Outdated

chatgpt-codex-connector Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread crates/goose-provider-types/src/formats/openai.rs Outdated

Comment thread crates/goose-provider-types/src/formats/openai.rs

chatgpt-codex-connector Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread crates/goose-provider-types/src/formats/openai.rs

chatgpt-codex-connector Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread crates/goose-providers/src/openai.rs

chatgpt-codex-connector Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread crates/goose-providers/src/openai.rs Outdated

Comment thread crates/goose-providers/src/anthropic.rs Outdated

chatgpt-codex-connector Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread crates/goose-providers/src/openai.rs Outdated

Comment thread crates/goose-providers/src/anthropic.rs Outdated

chatgpt-codex-connector Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread crates/goose-provider-types/src/model.rs

chatgpt-codex-connector Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread crates/goose-providers/src/ollama.rs

chatgpt-codex-connector Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread crates/goose-providers/src/openai.rs

Comment thread crates/goose-providers/src/ollama.rs

chatgpt-codex-connector Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread crates/goose-providers/src/openai.rs Outdated

chatgpt-codex-connector Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread crates/goose-providers/src/openai.rs Outdated

chatgpt-codex-connector Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread crates/goose-provider-types/src/formats/openai.rs

Comment thread crates/goose-sdk/src/bindings.rs Outdated

aaalaniz added 21 commits July 21, 2026 08:09

Fix explicit reasoning override being discarded

569a481

chore: format and fixes

2d50bde

fix(providers): update tests to use Reasoning enum

eaed111

fix(providers): address latest PR feedback on reasoning logic

7d1e9a2

fix(providers): resolve clippy warning on unnecessary lazy evaluation

0b8a6e7

feat(cerebras): configure reasoning for gpt-oss-120b and zai-glm-4.7

91be969

feat(cerebras): map reasoning_effort to thinking levels

d091c0e

Propagate declarative reasoning config to ModelConfig in agent.rs

df69695

Apply suggestion from @aaalaniz

7b943e9

Fix reasoning provider fallback for custom models that omit reasoning…

00e300e

… metadata

Honor 'Off' for custom reasoning effort by omitting reasoning paramet…

9053f3f

…ers for non-OpenAI models

Add effort_mapping to cerebras declarative models to allow Off to map…

aba3abc

… to none

Simplify cerebras effort_mapping

5695b86

Simplify zai-glm-4.7 effort_mapping

6812b2f

Add gemma4

b3754b8

Fix reasoning_is_explicit persistence and remove ToSchema

8f8f4ee

Apply Ollama thinking preservation formats

a70c1e9

Re-add thinking_preservation_format to gemma-4-31b

7535b75

Set preserves_thinking: true for Cerebras provider

7fff0a2

Merge reasoning config in update_provider

5c8c4db

Merge provider reasoning for non-explicit defaults

975c5fc

aaalaniz force-pushed the phase2-reasoning-refactor branch from a5d2c50 to 975c5fc Compare July 21, 2026 13:09

chatgpt-codex-connector Bot reviewed Jul 21, 2026

View reviewed changes

Comment thread crates/goose-providers/src/openai.rs Outdated

aaalaniz and others added 2 commits July 21, 2026 18:51

Let per-model preservation enable thinking replay

4798767

chatgpt-codex-connector Bot reviewed Jul 27, 2026

View reviewed changes

aaalaniz closed this Jul 28, 2026

aaalaniz mentioned this pull request Jul 28, 2026

fix(cerebras): preserve thinking inline for models that reject reasoning_content #10774

Merged

Conversation

aaalaniz commented Jul 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Uh oh!

aaalaniz commented Jul 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

aaalaniz commented Jul 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

aaalaniz commented Jul 13, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

aaalaniz commented Jul 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

aaalaniz commented Jul 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

aaalaniz commented Jul 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

aaalaniz commented Jul 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

aaalaniz commented Jul 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

aaalaniz commented Jul 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

aaalaniz commented Jul 14, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

aaalaniz commented Jul 14, 2026

aaalaniz commented Jul 13, 2026 •

edited

Loading