Add GPT-5.6 support - #10384
Conversation
e558fd5 to
3d7bf34
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e558fd5c30
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3d7bf34 to
f3b87b9
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3b87b9a64
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f3b87b9 to
b7ef5cf
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0bc46cb50b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 participants
Summary
Add GPT-5.6 model support for OpenAI and ChatGPT Codex, including updated reasoning effort handling, Responses API params, and regenerated canonical metadata.
Note: I ran
cargo run --bin build_canonical_modelsto pull frommodels.dev, which includes the GPT-5.6 family metadata. The generated files changed more than just GPT-5.6 because there was more in the upstream models.dev since the last generation.Testing
Added tests:
test_responses_request_supports_gpt_5_6_xhigh_efforttest_responses_request_omits_default_max_output_tokens_for_unknown_modeltest_responses_request_includes_canonical_max_output_tokenstest_known_model_names_include_gpt_5_6_modelstest_reasoning_levels_for_modeltest_create_codex_request_off_sets_none_for_gpt_5_6_modelsRan:
cargo test -p goose-provider-types openaicargo test -p goose-providers openaiIssue to be addressed later: #10385