Add GPT-5.6 family support - #10349
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 54793f96d9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4590c32718
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ("gpt-5.6-luna", 1_050_000), | ||
| ("gpt-5.6-sol", 1_050_000), | ||
| ("gpt-5.6-terra", 1_050_000), |
There was a problem hiding this comment.
Add canonical records before listing GPT-5.6
These IDs are only added to OPEN_AI_KNOWN_MODELS, but the refreshed inventory and session materialization paths rely on the canonical registry: fetch_recommended_models filters live /v1/models results through canonical mappings when any mapped OpenAI models exist, and with_canonical_limits uses the same registry for the session context limit. I checked rg "gpt-5\\.6|gpt-5-6" crates/goose-provider-types/src/canonical/data and there are no canonical records, so once OpenAI returns these IDs they will be dropped from refreshed recommended models; if entered manually/fallback, Goose falls back to 128k instead of the 1,050,000 limit listed here. Add matching canonical entries with the new models' limits/capabilities when exposing them.
Useful? React with 👍 / 👎.
|
Nice @michaelneale |
Summary
gpt-5.6-luna,gpt-5.6-sol, andgpt-5.6-terrawith their 1,050,000-token context windowsxhighreasoning effortVerification
reasoning.effort: xhigh: all three GPT-5.6 models accepted itcargo test -p goose-provider-types test_create_request_gpt56_max_effort_uses_xhighcargo test -p goose-providers gpt_5_5_and_5_6_models_have_expected_context_limitscargo clippy -p goose-provider-types -p goose-providers --all-targets -- -D warningscargo fmt --all