fix(desktop): relabel settings 'Session' tab to 'External Backend' - #10318
Merged
DOsinga merged 3 commits intoJul 8, 2026
Merged
Conversation
DOsinga
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Settings tab labeled "Session" (with the share icon) renders only the External Backend (ACP) configuration panel — nothing on it relates to sessions, so the label is misleading.
The label was correct when the tab was introduced as session sharing (#4370). PR #9994 ("Remove share session via base url") removed
<SessionSharingSection />from this tab, leaving only<ExternalBackendSection />, but thei18n.tabSessionlabel was never updated.This change relabels the tab to "External Backend" via a new
tabExternalBackendi18n key, with translations added for all supported locales. The internalvalue="sharing"anddata-testid="settings-sharing-tab"are intentionally left unchanged to avoid touching call sites and tests.Testing
Manual testing in the desktop app (
just run-ui→ Settings): the tab now reads "External Backend" and opens the External Backend (ACP) settings panel.Automated checks pass:
npx tsc --noEmit— no type errorsnode scripts/i18n-check.js— passesnode scripts/i18n-validate-locale.js— passes (all 16 locales carry the new key)Note: the non-English translations of "External Backend" are best-effort and would benefit from a native-speaker review.
Related Issues
Relates to #10317
Discussion: N/A
Screenshots/Demos (for UX changes)