Skip to content

Update Rust toolchain and raise recursion limit - #10303

Merged
jbg merged 4 commits into
mainfrom
jbg/update-rust-toolchain-recursion-limit
Jul 7, 2026
Merged

Update Rust toolchain and raise recursion limit#10303
jbg merged 4 commits into
mainfrom
jbg/update-rust-toolchain-recursion-limit

Conversation

@jbg

@jbg jbg commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Updates rust-toolchain.toml to Rust 1.96.1 and refreshes Cargo.lock with cargo update.
  • Raises the workspace MSRV to Rust 1.94.1.
  • Adds #![recursion_limit = "256"] to the crates that need it for deep macro/type expansion.
  • Cleans up Rust 1.96 clippy fallout from the toolchain and lockfile refresh.

Validation

  • cargo update
  • cargo fmt
  • cargo metadata --locked --no-default-features --format-version 1
  • cargo clippy --all-targets -- -D warnings
  • RUSTFLAGS="-D warnings" cargo +1.94.1 check -p goose --all-targets

@jbg
jbg force-pushed the jbg/update-rust-toolchain-recursion-limit branch from f4110c1 to 15bf35a Compare July 7, 2026 17:18
@jbg
jbg force-pushed the jbg/update-rust-toolchain-recursion-limit branch from 15bf35a to b6abc27 Compare July 7, 2026 21:18
@jbg
jbg marked this pull request as ready for review July 7, 2026 21:19
@jbg
jbg requested a review from lifeizhou-ap July 7, 2026 21:19

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b6abc271c6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/goose-cli/src/main.rs
@jbg
jbg added this pull request to the merge queue Jul 7, 2026
Merged via the queue into main with commit 651dc97 Jul 7, 2026
30 of 32 checks passed
@jbg
jbg deleted the jbg/update-rust-toolchain-recursion-limit branch July 7, 2026 22:57
lifeizhou-ap added a commit that referenced this pull request Jul 7, 2026
* main:
  Update Rust toolchain and raise recursion limit (#10303)
  Switch the local inference provider MLX backend to use the safemlx crate (#10304)
  feat: askai bot hints for followups (#10291)
  feat(desktop): per-message usage stats UI (tokens, cost, TTFT, tok/s) (#10210)
  fix(server): return effective context limit from /model-info (#10165)
  fix(deps): gate rcgen aws_lc_rs feature behind rustls-tls (#10116)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants