Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 39 additions & 35 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ async-trait = { version = "0.1.89", default-features = false }
axum = { version = "0.8", default-features = false, features = ["http1", "http2", "json", "tokio", "query"] }
base64 = { version = "0.22.1", default-features = false, features = ["std"] }
bytes = { version = "1.10.1", default-features = false, features = ["std"] }
candle-core = { version = "0.10", default-features = false }
candle-nn = { version = "0.10", default-features = false }
candle-core = { version = "0.11", default-features = false }
candle-nn = { version = "0.11", default-features = false }
chrono = { version = "0.4.44", default-features = false, features = ["serde", "std"] }
clap = { version = "4.1.14", default-features = false, features = ["derive", "std", "help", "suggestions", "usage", "color", "error-context"] }
dirs = { version = "6", default-features = false }
Expand Down
2 changes: 1 addition & 1 deletion crates/goose/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ unicode-normalization = { version = "0.1.22", default-features = false, features
# For local Whisper transcription (optional, behind "local-inference" feature)
candle-core = { workspace = true, optional = true }
candle-nn = { workspace = true, optional = true }
candle-transformers = { version = "0.10", default-features = false, optional = true }
candle-transformers = { version = "0.11", default-features = false, optional = true }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep Candle crates on the same version

When local-inference is enabled, this bump leaves goose depending directly on candle-core 0.10.2/candle-nn 0.10.2 while candle-transformers 0.11.0 pulls in candle-core 0.11.0/candle-nn 0.11.0 (see Cargo.lock). crates/goose/src/dictation/whisper.rs imports Device and Tensor from the direct candle-core dependency and passes them into candle_transformers APIs such as VarBuilder::from_gguf, encoder/decoder forward, and Whisper::load, so Rust treats those as different crate types and builds with --features local-inference (and dependent cuda/vulkan/mlx features) will fail. Please bump the workspace Candle crates together or keep candle-transformers on 0.10.

Useful? React with 👍 / 👎.

byteorder = { version = "1.5", default-features = false, features = ["std"], optional = true }
tokenizers = { version = "0.23", default-features = false, features = ["onig"], optional = true }
symphonia = { version = "0.5", default-features = false, features = ["aac", "adpcm", "alac", "isomp4", "mkv", "mp3", "pcm", "vorbis", "wav"], optional = true }
Expand Down
Loading