Fix canonical model output paths - #10196
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c8c847e595
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| crates/goose-providers/src/canonical/data/canonical_models.json \ | ||
| crates/goose-providers/src/canonical/data/provider_metadata.json | ||
| crates/goose-provider-types/src/canonical/data/canonical_models.json \ | ||
| crates/goose-provider-types/src/canonical/data/provider_metadata.json |
There was a problem hiding this comment.
Because prepare-release runs just build-canonical-models, the default checker also writes the tracked crates/goose-provider-types/src/canonical/data/canonical_mapping_report.json (and refreshes its timestamp) on every release run, but this git add only stages the other two generated files. In that workflow the release commit succeeds while leaving the mapping report dirty and out of the release commit; include the report in this staged file list as well.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
this file doesn't seem to have ever been committed, we can deal with this separately if necessary.
2 participants
The canonical model builder still wrote to the old goose-providers data directory after the canonical data moved into goose-provider-types.
This updates the builder output path and matching release/docs references so
just build-canonical-modelswrites to the existing provider-types data directory.Also added a deny.toml ignore for a second quick-xml vuln which we can't immediately remediate