Skip to content

Allow local file ACP origins - #10194

Merged
jh-block merged 1 commit into
mainfrom
desktop-acp-file-origin
Jul 2, 2026
Merged

jh-block merged 1 commit into
mainfrom
desktop-acp-file-origin

Conversation

@jh-block

@jh-block jh-block commented Jul 2, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • allow authenticated ACP defaults to accept local file origins (null and file://) alongside loopback origins
  • keep unauthenticated ACP defaults loopback-only
  • keep explicit --allowed-origin values as a full replacement for the default origin set
  • add regression coverage for WebSocket origin enforcement and CORS preflight behavior

Validation

  • cargo fmt
  • cargo test -p goose --test acp_transport_auth_test
  • cargo clippy -p goose --all-targets -- -D warnings

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: df9f9f25e9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/goose/tests/acp_transport_auth_test.rs
@jh-block
jh-block force-pushed the desktop-acp-file-origin branch from df9f9f2 to 0420754 Compare July 2, 2026 08:08
@jh-block jh-block changed the title Allow packaged desktop ACP origin Allow local file ACP origins Jul 2, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0420754e22

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/goose/src/acp/transport/mod.rs Outdated
@jh-block
jh-block force-pushed the desktop-acp-file-origin branch from 0420754 to 0941b10 Compare July 2, 2026 08:13

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0941b102e2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/goose/src/acp/transport/mod.rs
@jh-block
jh-block force-pushed the desktop-acp-file-origin branch from 0941b10 to d4acfc3 Compare July 2, 2026 08:21
@jh-block
jh-block requested a review from lifeizhou-ap July 2, 2026 08:30
@jh-block
jh-block added this pull request to the merge queue Jul 2, 2026
Merged via the queue into main with commit bf1a986 Jul 2, 2026
24 checks passed
@jh-block
jh-block deleted the desktop-acp-file-origin branch July 2, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants