fix(providers): add claude-sonnet-5 to canonical model registry - #10183
Merged
michaelneale merged 1 commit intoJul 2, 2026
Merged
Conversation
Add amazon-bedrock and anthropic entries for Claude Sonnet 5 so aws_bedrock resolves the 1M context window instead of falling back to 128k. Also register the model in BEDROCK_KNOWN_MODELS for picker completeness. Fixes aaif-goose#10179
michaelneale
approved these changes
Jul 2, 2026
michaelneale
left a comment
Collaborator
There was a problem hiding this comment.
Nice one, FYI:
$3/$15 vs actual $2/$10 - is probably only tweak (which I think will be corrected when regenerated)
also cargo run --bin build_canonical_models - can regenerate it I think
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
claude-sonnet-5entries to the canonical model registry so AWS Bedrock users get the correct 1M context window instead of the 128k default fallback.Motivation
global.anthropic.claude-sonnet-5on theaws_bedrockprovider currently resolves no canonical entry, sowith_canonical_limits()leavescontext_limitunset andcontext_limit()falls back to 128,000 tokens. The wiring is correct — this is a pure data gap until models.dev lists the model.Fixes #10179
Changes
amazon-bedrock/global.anthropic.claude-sonnet-5tocanonical_models.json(context: 1,000,000; output: 64,000), mirroring theclaude-sonnet-4.6global entryanthropic/claude-sonnet-5with the same limits andthinking_mode: adaptiveglobal.anthropic.claude-sonnet-5inBEDROCK_KNOWN_MODELSfor model-picker visibilityanthropic/claude-sonnet-5toinferred_thinking_modeinbuild_canonical_models.rsfor future registry rebuildsaws_bedrockandanthropicTests
All 7
with_canonical_limitstests andtest_map_to_canonical_modelpass.Notes
claude-sonnet-5, so these entries are hand-added per the issue's proposed fix. They can be refreshed viacargo run --bin build_canonical_modelsonce models.dev catches up.us.anthropic.claude-sonnet-5) are out of scope for this PR; only the global ID reported in claude-sonnet-5 missing from canonical model registry, falls back to 128k context limit on Bedrock #10179 is covered.