-
Notifications
You must be signed in to change notification settings - Fork 6k
fix(server): return effective context limit from /model-info #10165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DOsinga
merged 1 commit into
aaif-goose:main
from
piyushbag:fix/10163-model-info-context-limit
Jul 6, 2026
+65
−2
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Databricks endpoints whose name canonically parses differently from the resolved upstream model,
fetch_model_infohas already looked up the endpoint and computedinfo.context_limitfromresolved_model, but this branch overwrites it with the locally normalized endpoint-name limit. For example, an endpoint named likekgoose-gpt-4othat actually points at a larger Claude/GPT model will be reported with thegpt-4olimit instead of the upstream model's limit. Fresh evidence: this version avoids the old default fallback case, but line 505 still populatesmodel_config.context_limitfrom canonical/known metadata rather than only from an explicit user override.Useful? React with 👍 / 👎.