Skip to content

Fix/compact disabled during approval #10089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexhancock merged 4 commits into from
Jul 13, 2026
Merged

Fix/compact disabled during approval #10089

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9b0dfd5
Take into account isLoading too for compactButtonDisabled
thepetk Jun 28, 2026
98410be
Fix UI tests
thepetk Jul 6, 2026
887ee19
Merge remote-tracking branch 'origin/main' into fix/compact-disabled-…
Jul 8, 2026
990093e
Remove redundant compact button tests
Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ui/desktop/src/components/ChatInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,7 +655,7 @@ export default function ChatInput({
total: tokenLimit,
},
showCompactButton: true,
compactButtonDisabled: !totalTokens,
compactButtonDisabled: !totalTokens || isLoading,
onCompact: () => {
window.dispatchEvent(new CustomEvent(AppEvents.HIDE_ALERT_POPOVER));
handleSubmit({ msg: MANUAL_COMPACT_TRIGGER, images: [] });
Expand All @@ -664,9 +664,8 @@ export default function ChatInput({
});
}

// Keep alert recalculation scoped to token state changes.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [totalTokens, tokenLimit, isTokenLimitLoaded, addAlert, clearAlerts]);
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [totalTokens, tokenLimit, isTokenLimitLoaded, isLoading, addAlert, clearAlerts]);
Comment thread
thepetk marked this conversation as resolved.

// Cleanup effect for component unmount - prevent memory leaks
useEffect(() => {
Expand Down
Loading