Conversation
- Correct Windows `SetInformationJobObject` import - Dedupe React/React DOM in Vite renderer - Configure pnpm workspace for hoisted deps and allowed native builds - Refresh pnpm lockfile metadata
Collaborator
|
Thanks for the PR, and welcome! Unfortunately I don't think these changes are the right path, so I'm going to close this — let me explain why so it's useful for a next attempt.
None of these end up being net changes against current main, so I'll close this out. Please don't take it personally — for a first contribution we recommend starting with a small, targeted bug fix linked to an existing issue: https://github.com/aaif-goose/goose/blob/main/CONTRIBUTING.md#getting-started. Looking forward to a follow-up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the desktop React
useRefruntime error by deduping React/React DOM and updating pnpm workspace dependency resolution for hoisted/native builds. Also corrects a Windows job object import.useRefruntime error by deduping React/React DOMSetInformationJobObjectimportTesting
I have tested it locally, and it builds and runs without any issues after the fixes.