Skip to content

Fix Windows build and desktop dependency resolution - #10015

Closed
kursad-k wants to merge 1 commit into
aaif-goose:mainfrom
kursad-k:kk_v001
Closed

kursad-k wants to merge 1 commit into
aaif-goose:mainfrom
kursad-k:kk_v001

Conversation

@kursad-k

Copy link
Copy Markdown
Contributor

Summary

Fixes the desktop React useRef runtime error by deduping React/React DOM and updating pnpm workspace dependency resolution for hoisted/native builds. Also corrects a Windows job object import.

  • Fixes null useRef runtime error by deduping React/React DOM
  • Aligns workspace React versions and hoists pnpm dependencies
  • Allows required Electron/native dependency builds
  • Corrects Windows SetInformationJobObject import

Testing

I have tested it locally, and it builds and runs without any issues after the fixes.

- Correct Windows `SetInformationJobObject` import
- Dedupe React/React DOM in Vite renderer
- Configure pnpm workspace for hoisted deps and allowed native builds
- Refresh pnpm lockfile metadata
@DOsinga

DOsinga commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the PR, and welcome! Unfortunately I don't think these changes are the right path, so I'm going to close this — let me explain why so it's useful for a next attempt.

None of these end up being net changes against current main, so I'll close this out. Please don't take it personally — for a first contribution we recommend starting with a small, targeted bug fix linked to an existing issue: https://github.com/aaif-goose/goose/blob/main/CONTRIBUTING.md#getting-started. Looking forward to a follow-up!

@DOsinga DOsinga closed this Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants