Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a temporary fix to handle an edge case in the test test_classwise… #579

Merged
merged 3 commits into from
May 7, 2024

Conversation

schroedk
Copy link
Collaborator

@schroedk schroedk commented May 6, 2024

Description

This PR closes #474

Changes

  • FIx an edge case in the test test_classwise_scorer_accuracies_manual_derivation, empty train data leads to undefined behavior due to occurrence of np.nan and different resulting int conversions depending on operation system.

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "tags": ["hide"] or "tags": ["hide-input"]

@schroedk schroedk requested a review from kosmitive May 6, 2024 17:39
@schroedk schroedk marked this pull request as ready for review May 7, 2024 10:41
@schroedk schroedk requested a review from mdbenito May 7, 2024 10:41
@schroedk schroedk added this to the v0.9.2 milestone May 7, 2024
@schroedk schroedk merged commit c194d4d into develop May 7, 2024
35 checks passed
@schroedk schroedk deleted the fix/474-inconsistent-test branch May 7, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent test behavior
2 participants