Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSR method for Banzhaf #520

Merged
merged 47 commits into from
Apr 12, 2024
Merged

MSR method for Banzhaf #520

merged 47 commits into from
Apr 12, 2024

Conversation

jakobkruse1
Copy link
Collaborator

@jakobkruse1 jakobkruse1 commented Mar 18, 2024

Description

This PR closes #519

Changes

  • Implementing the MSR Banzhaf data valuation method

Checklist

  • Write code for MSR Banzhaf method
  • Write notebook that showcases MSR Banzhaf and compares it with normal Banzhaf
  • Ensure that the method works in parallel computation (Marginal has memory now which may be an issue)
  • Wrote Unit tests
  • Updated Documentation
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "tags": ["hide"] or "tags": ["hide-input"]

@jakobkruse1 jakobkruse1 added the new-method Implementation of new algorithms for valuation or influence functions label Mar 18, 2024
@jakobkruse1 jakobkruse1 self-assigned this Mar 18, 2024
@jakobkruse1 jakobkruse1 removed the request for review from mdbenito March 18, 2024 14:29
@jakobkruse1 jakobkruse1 changed the title WIP: MSR method for Banzhaf MSR method for Banzhaf Mar 18, 2024
@jakobkruse1 jakobkruse1 marked this pull request as ready for review March 28, 2024 09:37
@jakobkruse1
Copy link
Collaborator Author

@mdbenito @AnesBenmerzoug Any idea about the CI error? I don't think this is my fault. Have you seen that one before?

@mdbenito
Copy link
Collaborator

mdbenito commented Mar 29, 2024

@mdbenito @AnesBenmerzoug Any idea about the CI error? I don't think this is my fault. Have you seen that one before?

It's this: squidfunk/mkdocs-material#6983

I propose to just disable the plugin in this PR, since it's breaking all builds anyway, and to open a new issue to handle the situation / see how it develops over there.

plugins:
  - social:
      enabled: false

CHANGELOG.md Outdated Show resolved Hide resolved
@mdbenito mdbenito self-assigned this Apr 6, 2024
@mdbenito
Copy link
Collaborator

mdbenito commented Apr 6, 2024

@jakobkruse1 Please remove all warnings and irrelevant outputs (e.g. supress warnings, clean progress bars) before committing the notebook.

PS: I assigned myself to the PR. Our convention is assignee == merger, and merger is an additional reviewer.

@jakobkruse1
Copy link
Collaborator Author

@jakobkruse1 Please remove all warnings and irrelevant outputs (e.g. supress warnings, clean progress bars) before committing the notebook.

PS: I assigned myself to the PR. Our convention is assignee == merger, and merger is an additional reviewer.

Still working on finishing the notebook. Should be done soonish.
I can not suppress the warnings because they are raised in the parallel backend and suppressing them does not work as usual there. Any hint on how to do this?

@jakobkruse1 jakobkruse1 force-pushed the feature/msr-banzhaf branch 2 times, most recently from 5abf4af to 7140215 Compare April 8, 2024 13:39
@jakobkruse1
Copy link
Collaborator Author

Notebook is running, I will push everything once it is done. Then we can merge today.

mdbenito
mdbenito previously approved these changes Apr 12, 2024
@mdbenito mdbenito merged commit 67a5b06 into develop Apr 12, 2024
@mdbenito mdbenito deleted the feature/msr-banzhaf branch April 12, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-method Implementation of new algorithms for valuation or influence functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement MSR for Banzhaf
3 participants