-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/343 nystroem #504
Feature/343 nystroem #504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Maybe you could add an example on how to use Nystroem in the wine notebook. Right now the Arnoldi solver only shows the perc error, but you could add the correlation (like for ekfac) and then also do the same for Nystroem.
…proximation, import NystroemSketchInfluence in pydvl.influence.torch
…catter plots and correlation copmutation, add section for Lissa
@Xuzzo I extended the wine notebook to show the usage for Nystroem, added also correlation and scatter plots for Arnoldi, Cg, Lissa. |
Description
This PR closes #343
Changes
NystroemSketchInfluence
model_dtype
ofTorchInfluenceFunctionModel
Checklist
"tags": ["hide"]
or"tags": ["hide-input"]