Improve antithetic sampling #439

mdbenito · 2023-09-22T20:48:05Z

This PR closes fixes a bug in antithetic sampling and adds support for permutation antithetic sampling

When returning a complement set, do not add the index to the set since this results in no marginal being computed
Added AntitheticPermutationSampler

Wrote Unit tests (if necessary)
Updated Documentation (if necessary)
Updated Changelog
If notebooks were added/changed, added boilerplate cells are tagged with "tags": ["hide"] or "tags": ["hide-input"]

src/pydvl/value/sampler.py

# Conflicts: # CHANGELOG.md

mdbenito added 2 commits September 22, 2023 22:36

Fix antithetic powerset sampler

8f152de

Add antithetic permutation sampling

ae8bf13

mdbenito self-assigned this Sep 22, 2023

mdbenito added bug Something isn't working enhancement New feature or request labels Sep 22, 2023

mdbenito added 2 commits September 22, 2023 22:48

Update CHANGELOG.md

30bf434

Test new sampler

3942f34

mdbenito requested a review from AnesBenmerzoug September 22, 2023 20:51

mdbenito marked this pull request as ready for review September 22, 2023 20:51

[skip ci] Update bib

96817c9

AnesBenmerzoug reviewed Sep 23, 2023

View reviewed changes

src/pydvl/value/sampler.py Show resolved Hide resolved

mdbenito added 2 commits September 27, 2023 10:40

[skip ci] Add missing version notice

ed08d8c

Merge branch 'develop' into feature/antithetic-sampling

c804a4a

# Conflicts: # CHANGELOG.md

mdbenito mentioned this pull request Sep 30, 2023

Alternative permutation antithetic sampling #442

Open

mdbenito merged commit 23316c2 into develop Sep 30, 2023
12 checks passed

mdbenito deleted the feature/antithetic-sampling branch September 30, 2023 07:28

Provide feedback