Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ray an optional dependency #408

Merged
merged 8 commits into from
Aug 27, 2023
Merged

Make ray an optional dependency #408

merged 8 commits into from
Aug 27, 2023

Conversation

mdbenito
Copy link
Collaborator

@mdbenito mdbenito commented Aug 26, 2023

Description

This PR closes #380 #367 .

Changes

Because we are already using a sub-class registry, there was little to do:

  • Moved ParallelBackends into separate modules
  • Guard imports
  • Adapt the tests to skip if ray is not available. Not very elegant, but the alternative was to change the fixture parallel_backend and that would have meant a lot more changes. Ideas? (I'd just leave it as is tbh)
  • Documentation is missing, waiting until we have Ditch sphinx #261 to avoid silly conflicts

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "nbsphinx":"hidden"

@mdbenito mdbenito requested a review from schroedk August 26, 2023 17:26
@mdbenito mdbenito linked an issue Aug 26, 2023 that may be closed by this pull request
@mdbenito mdbenito added the packaging Library packaging and releasing label Aug 26, 2023
@mdbenito mdbenito self-assigned this Aug 27, 2023
@mdbenito mdbenito merged commit 6f8cda9 into develop Aug 27, 2023
0 of 6 checks passed
@mdbenito mdbenito deleted the feature/optional-ray branch August 27, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Library packaging and releasing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ray dependency optional Ray via pip not working for Apple ARM-based CPU
2 participants