Refactoring/influence #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* simplify grad method, do not return tuple, simplify input signature * simplify split_grad to call self.grad * change default argument of self.grad * extract split_grad method to simplify class
…s, add torch implementation
* introduce a dynamic registry for inversion methods * make top level modules independent of the torch implementation
Xuzzo
reviewed
Aug 8, 2023
…igned with model named parameters), improve documentation
This was referenced Aug 17, 2023
mdbenito
requested changes
Aug 20, 2023
* improve format * improve naming
mdbenito
approved these changes
Aug 21, 2023
* add missing methods to interface, remove obsolete ones, make cat preallocate tensor * add DataLoaderUtilities concept
* remove DataLoaderUtilities * try to call len on dataloader for pre-allocating result tensor, fallback to ordinary cat
This was referenced Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a cleanup on how we can handle different frameworks. I would like to start from this, to add the jax framework and an additional method (Nyström approximation #343). This is not breaking the user interface again, as it is only modifying internal mechanisms of the package.
Changes
Checklist
[ ] If notebooks were added/changed, added boilerplate cells are tagged with"nbsphinx":"hidden"