Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in influence #358

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Fix bugs in influence #358

merged 4 commits into from
Jun 29, 2023

Conversation

Xuzzo
Copy link
Collaborator

@Xuzzo Xuzzo commented Jun 8, 2023

Description

This PR closes #357, #356

Changes

  • Moves break condition up in cg
  • adds device in identity_tensor

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "nbsphinx":"hidden"

@Xuzzo Xuzzo self-assigned this Jun 8, 2023
@Xuzzo Xuzzo requested a review from murong-xu June 8, 2023 12:31
@murong-xu
Copy link

I checked, everything fine, thanks!

@mdbenito
Copy link
Collaborator

mdbenito commented Jun 22, 2023

@Xuzzo Can you get the checks to pass and merge this? We have #365 almost ready to be merged and it will be affected by whatever you do here. Kristof will then proceed to rewrite some interfaces and should be able to start from code that works ok.

@mdbenito mdbenito linked an issue Jun 22, 2023 that may be closed by this pull request
@AnesBenmerzoug
Copy link
Collaborator

AnesBenmerzoug commented Jun 28, 2023

@Xuzzo The docs failure is due to a missing appendix section in the influence imagenet notebook.

@mdbenito The test failure comes from somewhere else though (It also appears in the develop branch, which is weird). I will try to fix that in a separate PR.

@mdbenito
Copy link
Collaborator

@Xuzzo The docs failure is due to a missing appendix section in the influence imagenet notebook.

@mdbenito The test failure comes from somewhere else though (It also appears in the develop branch, which is weird). I will try to fix that in a separate PR.

I think @schroedk has suffered the issue as well in #365

@mdbenito
Copy link
Collaborator

@Xuzzo In the future, please follow the branch naming conventions!

@mdbenito mdbenito merged commit ce4bdd1 into develop Jun 29, 2023
0 of 6 checks passed
@mdbenito mdbenito deleted the fix_bugs_influences branch June 29, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZeroDivisionError in conjugate gradient method Specify device in solve_linear()
4 participants