Change get to pop in compute_semivalues. #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kosmitive looks good to me. Could you please merge develop to your branch and then update the changelog? |
|
I'm curious as to how this error manifests itself and why the tests didn't catch it. @kosmitive Maybe you could extend the tests? |
|
@AnesBenmerzoug @mdbenito Please recheck the newly added test case, then I would merge it! |
Co-authored-by: Anes Benmerzoug <[email protected]>
Co-authored-by: Anes Benmerzoug <[email protected]>
AnesBenmerzoug
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #330
Checklist
Updated Documentation (if necessary)If notebooks were added/changed, added boilerplate cells are tagged with"nbsphinx":"hidden"