Semi-values and samplers #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/pydvl/value/results.py
# Conflicts: # README.md # src/pydvl/utils/numeric.py # src/pydvl/value/results.py
# Conflicts: # src/pydvl/utils/numeric.py # src/pydvl/value/loo/naive.py # src/pydvl/value/results.py # src/pydvl/value/shapley/knn.py # src/pydvl/value/shapley/montecarlo.py # src/pydvl/value/shapley/naive.py # src/pydvl/value/stopping.py # tests/test_results.py # tests/value/conftest.py # tests/value/loo/conftest.py
This was referenced Mar 12, 2023
|
According to semver.org, adding new functionality should not go into a patch version. Only backwards compatible bug fixes should be part of it. This should be split. The bug fixes can be part of 0.5.1 and the rest can be part of 0.6.0 |
AnesBenmerzoug
approved these changes
Mar 13, 2023
…atorialSampler, test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #121, closes #224 and closes #225. It doesn't remove any previous functionality and thus could make it into https://github.com/appliedAI-Initiative/pyDVL/milestone/14 .
Things missing (for other PRs)
Changes
PowersetSamplerand several specializations for uniform, antithetic, deterministic, or permutation sampling.Coefficient, with only one function allowing for all combinationsStoppingCriterion.completion()Checklist
If notebooks were added/changed, added boilerplate cells are tagged with"nbsphinx":"hidden"