Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF refactoring and further testing #278

Merged
merged 63 commits into from
May 19, 2023
Merged

IF refactoring and further testing #278

merged 63 commits into from
May 19, 2023

Conversation

Xuzzo
Copy link
Collaborator

@Xuzzo Xuzzo commented Feb 24, 2023 •
edited
Loading

Description

This PR closes #137 and closes #169 and closes #203 and closes #130 and closes #168 and closes #306
It also closes #222: wrappers have been removed and only one fitting method is used, now outside src (put in notebook_support).

Changes

  • Several refactorings of influence functions code
  • included if tests with several NN architectures and more detailed ones using linear models
  • removed useless framework wrappers and boilerplate from source code
  • Re-runs notebooks with new (slightly) modified interface

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "nbsphinx":"hidden"

@Xuzzo Xuzzo changed the title Test influence refactoring IF refactoring and further testing Feb 24, 2023
@Xuzzo Xuzzo changed the title IF refactoring and further testing Draft: IF refactoring and further testing Feb 24, 2023
mdbenito
mdbenito reviewed Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@mdbenito mdbenito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few comments in two files but I'm calling it a day. Will continue soon

src/pydvl/influence/frameworks/torch_differentiable.py Outdated Show resolved Hide resolved
notebooks/notebook_support.py Outdated Show resolved Hide resolved
notebooks/notebook_support.py Outdated Show resolved Hide resolved
notebooks/notebook_support.py Outdated Show resolved Hide resolved
notebooks/notebook_support.py Outdated Show resolved Hide resolved
notebooks/notebook_support.py Outdated Show resolved Hide resolved
notebooks/notebook_support.py Outdated Show resolved Hide resolved
notebooks/notebook_support.py Outdated Show resolved Hide resolved
notebooks/notebook_support.py Outdated Show resolved Hide resolved
notebooks/notebook_support.py Outdated Show resolved Hide resolved
@mdbenito mdbenito marked this pull request as draft February 25, 2023 19:09
mdbenito
mdbenito reviewed Feb 25, 2023
View reviewed changes
Copy link
Collaborator

@mdbenito mdbenito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few more comments and some discussion on how to avoid the checks for modules inside the functions, which might pave the way towards #282

CHANGELOG.md Outdated Show resolved Hide resolved
tests/influence/conftest.py Outdated Show resolved Hide resolved
tests/influence/conftest.py Outdated Show resolved Hide resolved
tests/influence/conftest.py Outdated Show resolved Hide resolved
tests/influence/conftest.py Outdated Show resolved Hide resolved
src/pydvl/influence/frameworks/torch_differentiable.py Outdated Show resolved Hide resolved
mdbenito
mdbenito reviewed Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@mdbenito mdbenito left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few more comments

notebooks/notebook_support.py Outdated Show resolved Hide resolved
notebooks/notebook_support_torch.py Outdated Show resolved Hide resolved
src/pydvl/influence/frameworks/torch_differentiable.py Outdated Show resolved Hide resolved
src/pydvl/influence/general.py Outdated Show resolved Hide resolved
src/pydvl/influence/general.py Outdated Show resolved Hide resolved
src/pydvl/influence/inversion_methods.py Outdated Show resolved Hide resolved
src/pydvl/influence/inversion_methods.py Outdated Show resolved Hide resolved
src/pydvl/influence/types.py Outdated Show resolved Hide resolved
src/pydvl/influence/general.py Outdated Show resolved Hide resolved
src/pydvl/influence/general.py Outdated Show resolved Hide resolved
This was linked to issues Mar 10, 2023
Investigate flakiness of influence values #130
Closed
Label all unreliable IF code and documentation as experimental #203
Closed
Inspect use of Pytorch lightning to replace TorchWrappers #222
Closed
Xuzzo and others added 23 commits April 4, 2023 13:55
@Xuzzo
implement cg in pytorch
f1fb972
@Xuzzo
WIP lissa
b9755b7
@Xuzzo
iterative solver - include lissa
ca7b50f
@Xuzzo
included data loaders
a7f9b4a
@Xuzzo
update notebooks and clean tests
20390a4
@Xuzzo
makes x requires grad optional
48d564c
@Xuzzo
shuffling data loader before lissa
d8d4dac
@Xuzzo
cleanup a few more tests
3f385a6
@Xuzzo
add tests for lissa
7df4394
@Xuzzo
log residuals in lissa solver
bccc7d0
@Xuzzo
fix typing
7327de8
@Xuzzo
minor docstring changes
041d5a2
@Xuzzo
fix docs
5606e5c
@Xuzzo
fix keyword only args
be62a77
@Xuzzo
very minor change
493a5f4
@Xuzzo
fixing docstrings
81bb6b9
@Xuzzo
refactor test and minor doc changes
33818cc
@Xuzzo
use TensorDataset to save memory
0099995
@mdbenito
Merge pull request #339 from appliedAI-Initiative/feature/make_if_great
6f8233d
@mdbenito
Merge branch 'develop' into test_influence_refactoring
9180dfc 
# Conflicts:
#	CHANGELOG.md
#	src/pydvl/influence/conjugate_gradient.py
#	src/pydvl/utils/numeric.py
@mdbenito
Fix types
0b44769
@mdbenito
Fix bib after merge
ee8089e
@mdbenito
More doc fixes
9d1856a
mdbenito
mdbenito approved these changes May 19, 2023
View reviewed changes
Copy link
Collaborator

@mdbenito mdbenito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of thing still to do, but we need to merge

@mdbenito mdbenito merged commit d5381d7 into develop May 19, 2023
@mdbenito mdbenito deleted the test_influence_refactoring branch May 19, 2023 13:55
@mdbenito mdbenito mentioned this pull request Jun 29, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdbenito mdbenito mdbenito approved these changes

@AnesBenmerzoug AnesBenmerzoug Awaiting requested review from AnesBenmerzoug

Assignees

@Xuzzo Xuzzo

Labels
cleanup when code is ugly or unreadable and needs restyling testing Writing and verifying tests (unit or otherwise)
Projects
None yet
Milestone
v0.7.0
3 participants
@Xuzzo @mdbenito @AnesBenmerzoug