Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #249: allow negative n_jobs #270

Merged
merged 6 commits into from
Feb 20, 2023
Merged

Fix #249: allow negative n_jobs #270

merged 6 commits into from
Feb 20, 2023

Conversation

mdbenito
Copy link
Collaborator

@mdbenito mdbenito commented Feb 19, 2023 •
edited
Loading

Description

This PR closes #249

Changes

  • Adds a convenience effective_n_jobs and uses it. n_jobs is guaranteed to be >=1
  • Adds tests

Checklist

  • Wrote Unit tests (if necessary)
  • Updated Documentation (if necessary)
  • Updated Changelog
  • If notebooks were added/changed, added boilerplate cells are tagged with "nbsphinx":"hidden"

@mdbenito mdbenito added the bug Something isn't working label Feb 19, 2023
@mdbenito mdbenito self-assigned this Feb 19, 2023
@mdbenito mdbenito marked this pull request as ready for review February 19, 2023 21:45
@mdbenito mdbenito merged commit fcb5165 into develop Feb 20, 2023
@mdbenito mdbenito deleted the fix/249-negative-njobs branch February 20, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnesBenmerzoug AnesBenmerzoug AnesBenmerzoug approved these changes

Assignees

@mdbenito mdbenito

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting n_jobs=-1 runs only one iteration per job
2 participants
@mdbenito @AnesBenmerzoug