-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for GTShapley and scorers #264
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mdbenito
commented
Feb 20, 2023
@AnesBenmerzoug I'm afraid there is an error here that I fixed in #267 and the checks will keep failing. I would merge both in succession |
Co-authored-by: Anes Benmerzoug <[email protected]>
AnesBenmerzoug
approved these changes
Feb 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the one comment and one question that I left, this looks good to me and could be merged as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This PR must be merged after #265
Description
This PR revolves around fixes for Group Testing Shapley. PR #267 will add some missing tests (e.g.
Scorer
)Changes
utils/score.py
and theScorer
type to include information about range and default values when usingcompose_score
. This is need e.g. for Group Testing, where an accurate range is necessary.highs
would fail to find solutions in the presence of outlier data.test_gt.py
and adds more tests using group testing.Checklist
If notebooks were added/changed, added boilerplate cells are tagged with"nbsphinx":"hidden"