Fix using remote ray actor with external cluster #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The former was removed from sklearn starting from version 1.2
Sphinx struggles with vertical bars in math
mdbenito
reviewed
Jan 18, 2023
Co-authored-by: Miguel de Benito Delgado <[email protected]>
mdbenito
approved these changes
Jan 19, 2023
Comment on lines
+108
to
+109
| assert u1.signature == u1.signature | ||
| assert u2.signature == u2.signature |
There was a problem hiding this comment.
Yes. I just wanted to be extra sure since it's a property.
Right now it's redundant though.
| ): | ||
| self.model = model | ||
| self.model = self._clone_model(model) |
There was a problem hiding this comment.
We should document this too: if a clone is expensive, the user must know this will happen
There was a problem hiding this comment.
You're right. Sorry for not doing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug when instantiating
RayActorWrapperon an Actor that's present on an external cluster (i.e. one that was not started withray.init().Additionally, this modifies the
Utilityclass' handling of warnings so that when using ray with small subsetswe don't end up seeing the same warning message over and over again across workers (e.g. using Naive Bayes with TMC).
Changes
RayActorWrapper.Checklist
"nbsphinx":"hidden"