-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix using remote ray actor with external cluster #247
Fix using remote ray actor with external cluster #247
Conversation
The former was removed from sklearn starting from version 1.2
Sphinx struggles with vertical bars in math
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I left my usual pesky suggestions and small comments :)
Co-authored-by: Miguel de Benito Delgado <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a little mistake in the tests but I'm going to merge and fix it in my PR if that's ok bc I need to merge in these changes tonight.
assert u1.signature == u1.signature | ||
assert u2.signature == u2.signature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I just wanted to be extra sure since it's a property.
Right now it's redundant though.
): | ||
self.model = model | ||
self.model = self._clone_model(model) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should document this too: if a clone is expensive, the user must know this will happen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. Sorry for not doing it.
Description
This PR fixes a bug when instantiating
RayActorWrapper
on an Actor that's present on an external cluster (i.e. one that was not started withray.init()
.Additionally, this modifies the
Utility
class' handling of warnings so that when using ray with small subsetswe don't end up seeing the same warning message over and over again across workers (e.g. using Naive Bayes with TMC).
Changes
RayActorWrapper
.Checklist
"nbsphinx":"hidden"