Add lakectl config support #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assumes the default location (~/.lakectl.yaml), and loads the config file if it exists and YAML is installed. If YAML is not installed (this is not a hard requirement), it is possible to install it via `python -m pip install lakefs-spec[yaml]`.
For reading in `lakectl` configuration files. Also ignores missing imports from `pyyaml` under mypy.
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #45 +/- ##
==========================================
- Coverage 71.37% 68.79% -2.58%
==========================================
Files 3 3
Lines 262 282 +20
Branches 45 47 +2
==========================================
+ Hits 187 194 +7
- Misses 59 71 +12
- Partials 16 17 +1
☔ View full report in Codecov by Sentry. |
Saves a `Path.expanduser` in the `LakectlConfig.read()`.
Since we now have three rivaling modes of initialization for the file system, it is time to test the priority order is correct. This brought up a quirk related to instance caching: Since both the `lakectl` config file and environment variables are read implicitly, they do not require arguments, and thus the first method used between config file and envvar initialization will cause cache hits, and suffocate the other method unless the cache is cleared.
nicholasjng
force-pushed
the
add-lakectl-config-support
branch
from
4835119
to
88ead49
Compare
Explains the caveat of implicit initializations from envvars and lakectl config files together with the instance cache. Also changes the install instructions to bare `pip install` commands.
maxmynter
reviewed
Aug 30, 2023
If the file exists, we enter the `LakectlConfig.read()` method. There, we conditionally abort if `pyyaml` is not installed. If `pyyaml` is not installed, emit a warning that it cannot be found, and a solution (i.e. a pip install).
maxmynter
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assumes the default location (
~/.lakectl.yaml), and loads the config file if it exists and YAML is installed.If YAML is not installed (this is not a hard requirement), it is possible to install it via
python -m pip install lakefs-spec[yaml]. This extra is added specifically forlakectlconfiguration file support.Also ignores missing imports from
pyyamlunder mypy.Closes #43.