Batch objects in Branch.delete_objects calls
#285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lakeFS supports a maximum of 1000 objects per `delete_objects()` invocation, since that calls the object deletion API under the hood. This limitation is not without precedent, and exists also e.g. on AWS S3. Hence, we batch delete objects on the client side, dispatching multiple API calls in the cases where the deleted objects list contains more than a thousand objects. The threshold number of objects is currently hardcoded to 1000, since that is the limitation of the lakeFS server.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
==========================================
- Coverage 93.99% 93.19% -0.80%
==========================================
Files 5 5
Lines 383 397 +14
Branches 72 77 +5
==========================================
+ Hits 360 370 +10
- Misses 14 16 +2
- Partials 9 11 +2 ☔ View full report in Codecov by Sentry. |
|
Not really interested in covering these missing lines - one is a Python standard library call (if Python is at least version 3.12), the other is a guard against the edge case of a nonpositive chunk size (which is impossible for us, but still good to have). Interested in review opinions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lakeFS supports a maximum of 1000 objects per
delete_objects()invocation, since that calls the object deletion API under the hood. This limitation is not without precedent, and exists also e.g. on AWS S3.Hence, we batch delete objects on the client side, dispatching multiple API calls in the cases where the deleted objects list contains more than a thousand objects.
The threshold number of objects is currently hardcoded to 1000, since that is the limitation of the lakeFS server.
Fixes #284.