Update pre-commit hooks, change lockfile to use uv pip compile #278
Conversation
|
Can you also update |
uv is much faster and thus more appropriate for a mandatory commit hook. NB: setuptools is now in the lockfile, because uv does not have a "unsafe package exclusion" facility. duckdb was downgraded to v0.10.0, which is the last version without segfaults on cleanup with registered file systems.
In place of regular pip-compile.
We were getting some bad accesses (key errors) on empty-body API responses from the lakeFS server, causing a crash in the error handling.
This solution lets us upgrade the mkdocs tech stack, while not abandoning strict mode just for the git-revision plugin. The root cause for the previous failures is not yet determined, but has something to do with recent mkdocs/mkdocs-material updates.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
==========================================
- Coverage 94.54% 94.02% -0.52%
==========================================
Files 5 5
Lines 385 385
Branches 72 72
==========================================
- Hits 364 362 -2
- Misses 13 14 +1
- Partials 8 9 +1 ☔ View full report in Codecov by Sentry. |
|
So codecov fails the pipeline every time code is deleted from the repo because of the percentage changes? ¯\_(ツ)_/¯ |
It's set up to prevent PRs with decreasing coverage atm. It seems that coverage actually went down in
It seems that one of the dependency updates might have made that |
|
I've configured Codecov to allow PRs that decrease coverage by 1% at most in 0f7b811. As discussed on Slack, the check in |
uv is much faster and thus more appropriate for a mandatory commit hook.
NB: setuptools is now in the lockfile, because uv does not have a "unsafe package exclusion" facility.