Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RTL support for Colorize animation. Resolves #109 #164

Merged
merged 1 commit into from
Dec 6, 2020

Conversation

awhitford
Copy link
Collaborator

Added textDirection parameter to ColorizeAnimatedText and ColorizeAnimatedTextKit to support RTL text.

@codecov
Copy link

codecov bot commented Dec 5, 2020

Codecov Report

Merging #164 (0c68d71) into master (c3cbb6c) will decrease coverage by 0.33%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
- Coverage   91.34%   91.01%   -0.34%     
==========================================
  Files           9        9              
  Lines         439      445       +6     
==========================================
+ Hits          401      405       +4     
- Misses         38       40       +2     
Impacted Files Coverage Δ
lib/src/colorize.dart 92.68% <80.00%> (-4.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3cbb6c...0c68d71. Read the comment docs.

Copy link
Owner

@aagarwal1012 aagarwal1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aagarwal1012 aagarwal1012 merged commit df9c63a into aagarwal1012:master Dec 6, 2020
@awhitford awhitford deleted the rtl-colorize branch December 6, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants