Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilt example app #162

Merged
merged 1 commit into from
Nov 29, 2020
Merged

Conversation

awhitford
Copy link
Collaborator

  • Updated for Android Embedding V2.
  • Replaced Java with Kotlin, and Objective-C with Swift (the new defaults).
  • Removed .idea folder since it should not be committed (according to .gitignore).
  • Upgraded cupertino_icons dependency.
  • Updated for consistency with latest conventions.

@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

Merging #162 (6ad92d2) into master (2eda303) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   91.34%   91.34%           
=======================================
  Files           9        9           
  Lines         439      439           
=======================================
  Hits          401      401           
  Misses         38       38           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eda303...6ad92d2. Read the comment docs.

Copy link
Owner

@aagarwal1012 aagarwal1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aagarwal1012 aagarwal1012 merged commit c3cbb6c into aagarwal1012:master Nov 29, 2020
@aagarwal1012 aagarwal1012 added the enhancement New feature or request label Nov 29, 2020
@awhitford awhitford deleted the example-rebuild branch November 29, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants