Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a mounted guard before setState. #143

Merged
merged 1 commit into from
Nov 1, 2020

Conversation

awhitford
Copy link
Collaborator

Replaces PR #103 to correct an Unhandled Exception: setState() called after dispose() in ScaleAnimatedTextKit, reported by @asionbo.

@codecov
Copy link

codecov bot commented Nov 1, 2020

Codecov Report

Merging #143 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   81.99%   81.99%           
=======================================
  Files           8        8           
  Lines         761      761           
=======================================
  Hits          624      624           
  Misses        137      137           
Impacted Files Coverage Δ
lib/src/scale.dart 77.55% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b7affc...548c865. Read the comment docs.

Copy link
Owner

@aagarwal1012 aagarwal1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants