Corrected alignment adjustment logic. #138
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of my recent changes replaced the logic in
RotateAnimatedTextKit
to handle thealignment
property. The new logic was revised to use the+
operator, which assumed thatalignment
was anAlignment
. However, it is actually anAlignmentGeometry
, so the code was reverted to use theadd
method, which can accommodateAlignment
orAlignmentDirectional
. Ultimately, anAlignment
is required by theAlignmentTween
, so theadd
result needs to be resolved, which requires thetextDirection
. The final code is type safe.textDirection
toRotateAnimatedTextKit
which was necessary to accommodate anAlignmentGeometry
override.Alignment
constants with built-in constants making it easier to read and maintain.onTap
callback forRotateAnimatedTextKit
and boost code coverage.