Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked the basic smoke test to improve code coverage. #135

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

awhitford
Copy link
Collaborator

Overall an increase of about 10%, but opportunity still remains.

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #135 into master will increase coverage by 9.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   61.68%   71.55%   +9.87%     
==========================================
  Files           8        8              
  Lines         770      770              
==========================================
+ Hits          475      551      +76     
+ Misses        295      219      -76     
Impacted Files Coverage Δ
lib/src/rotate.dart 62.38% <0.00%> (+1.83%) ⬆️
lib/src/text_liquid_fill.dart 88.88% <0.00%> (+2.46%) ⬆️
lib/src/scale.dart 60.20% <0.00%> (+3.06%) ⬆️
lib/src/fade.dart 57.30% <0.00%> (+3.37%) ⬆️
lib/src/colorize.dart 75.90% <0.00%> (+3.61%) ⬆️
lib/src/typer.dart 66.66% <0.00%> (+13.09%) ⬆️
lib/src/typewriter.dart 67.28% <0.00%> (+18.69%) ⬆️
lib/src/wavy.dart 92.43% <0.00%> (+26.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4028ab0...2d3c60a. Read the comment docs.

Copy link
Owner

@aagarwal1012 aagarwal1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great 👍

@aagarwal1012 aagarwal1012 merged commit 5b78fa0 into aagarwal1012:master Oct 23, 2020
@awhitford awhitford deleted the testcov branch October 23, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants