Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redundant duplicate logic. #134

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

awhitford
Copy link
Collaborator

While investigating code coverage, I noticed redundant logic that can be simplified.

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #134 into master will increase coverage by 0.68%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   61.68%   62.36%   +0.68%     
==========================================
  Files           8        8              
  Lines         770      760      -10     
==========================================
- Hits          475      474       -1     
+ Misses        295      286       -9     
Impacted Files Coverage Δ
lib/src/rotate.dart 65.65% <100.00%> (+5.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4028ab0...d32121d. Read the comment docs.

Copy link
Owner

@aagarwal1012 aagarwal1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aagarwal1012 aagarwal1012 merged commit 2324d91 into aagarwal1012:master Oct 23, 2020
@awhitford awhitford deleted the rotate_dup branch October 23, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants