Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed redundant _texts variables. #133

Merged
merged 2 commits into from
Oct 23, 2020

Conversation

awhitford
Copy link
Collaborator

  • Colorize
    • Added a _timer variable so that it can be properly canceled during dispose.
    • Updated code to use proper Character counting so that it is Emoji friendly.
  • Typewriter
    • Corrected code to use proper Character counting so that it is Emoji friendly.
  • General
    • Added types to Animation declarations.
    • Removed the redundant _texts variables.
    • Updated code to satisfy pedantic rules.

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #133 into master will decrease coverage by 1.62%.
The diff coverage is 58.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   63.31%   61.68%   -1.63%     
==========================================
  Files           8        8              
  Lines         766      770       +4     
==========================================
- Hits          485      475      -10     
- Misses        281      295      +14     
Impacted Files Coverage Δ
lib/src/fade.dart 53.93% <30.00%> (-2.74%) ⬇️
lib/src/scale.dart 57.14% <30.00%> (-2.46%) ⬇️
lib/src/rotate.dart 60.55% <40.00%> (-1.06%) ⬇️
lib/src/typer.dart 53.57% <46.66%> (-2.90%) ⬇️
lib/src/typewriter.dart 48.59% <57.89%> (-1.41%) ⬇️
lib/src/colorize.dart 72.28% <67.64%> (-7.17%) ⬇️
lib/src/wavy.dart 65.54% <75.00%> (+1.08%) ⬆️
lib/src/text_liquid_fill.dart 86.41% <80.00%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fce7109...dc6ed02. Read the comment docs.

..addStatusListener(_animationEndCallback);
_typewriterText = StepTween(
begin: 0,
end: textLen + 8,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does anybody know why 8 is being added? What is significant about 8?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 is added for the _ typing animation after the given text is animated or typed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 8 and not 1?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk it's a random number that I added at the time of development, a lot of code has been changed after that.

@awhitford
Copy link
Collaborator Author

Investigating #128 led me to realize that TextLiquidFill has a bug where the wave animation continues to repeat even after the load has completed, so I added a fix to stop that.

@aagarwal1012
Copy link
Owner

@awhitford, your suggested changes look good to me, great work! 💯

@aagarwal1012 aagarwal1012 merged commit 4028ab0 into aagarwal1012:master Oct 23, 2020
@awhitford awhitford deleted the redundant_texts branch October 23, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants