-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TickerProvider -> Singletickerprovider #124
TickerProvider -> Singletickerprovider #124
Conversation
…t-Kit into singletickerprovider
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
==========================================
+ Coverage 68.78% 69.04% +0.26%
==========================================
Files 8 8
Lines 708 714 +6
==========================================
+ Hits 487 493 +6
Misses 221 221
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Note that I did not run this code -- just reviewed it.
It was running on my device(Android). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@SirusCodes, thanks for your contribution. I have sent you a collaborator invite, hope to see more contributions from you. |
Thanks a lot😊💙 |
Did changes in fade, rotate and scale. Thanks to @awhitford for fixing
Timer
issues😊Issue number #119