Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Properly disposed of Timer for Rotate, Scale, and Typer. #123

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

awhitford
Copy link
Collaborator

Separate PRs were submitted for Fade and Typewriter -- the fix is the same. Impacts issue #119.

Pull Request Process

  1. Ensure any install or build dependencies are removed before the end of the layer when doing a build.
  2. Update the README.md if needed with details of changes to the interface, this includes new environment variables, exposed ports, useful file locations and container parameters.
  3. Increase the version numbers in any examples files and the README.md to the new version that this Pull Request would represent. The versioning scheme we use is SemVer.
  4. You may merge the Pull Request in once you have the sign-off of one developer, or if you do not have permission to do that, you may request the second reviewer to merge it for you.

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #123 into master will decrease coverage by 0.45%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   68.63%   68.18%   -0.46%     
==========================================
  Files           8        8              
  Lines         695      704       +9     
==========================================
+ Hits          477      480       +3     
- Misses        218      224       +6     
Impacted Files Coverage Δ
lib/src/rotate.dart 65.65% <33.33%> (-1.02%) ⬇️
lib/src/scale.dart 65.88% <33.33%> (-1.20%) ⬇️
lib/src/typer.dart 63.29% <33.33%> (-1.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efdccb5...8691283. Read the comment docs.

Copy link
Owner

@aagarwal1012 aagarwal1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aagarwal1012 aagarwal1012 merged commit cb43a4d into aagarwal1012:master Oct 12, 2020
@awhitford awhitford deleted the timer_dispose branch October 12, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants