Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensured that the timer has been canceled. Resolves #98. #121

Merged
merged 1 commit into from
Oct 12, 2020

Conversation

awhitford
Copy link
Collaborator

Pull Request Process

  1. Ensure any install or build dependencies are removed before the end of the layer when doing a build.
  2. Update the README.md if needed with details of changes to the interface, this includes new environment variables, exposed ports, useful file locations and container parameters.
  3. Increase the version numbers in any examples files and the README.md to the new version that this Pull Request would represent. The versioning scheme we use is SemVer.
  4. You may merge the Pull Request in once you have the sign-off of one developer, or if you do not have permission to do that, you may request the second reviewer to merge it for you.

@codecov
Copy link

codecov bot commented Oct 11, 2020

Codecov Report

Merging #121 into master will decrease coverage by 0.15%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   68.35%   68.20%   -0.16%     
==========================================
  Files           8        8              
  Lines         689      692       +3     
==========================================
+ Hits          471      472       +1     
- Misses        218      220       +2     
Impacted Files Coverage Δ
lib/src/fade.dart 62.33% <33.33%> (-1.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa78a43...8f1765e. Read the comment docs.

@awhitford
Copy link
Collaborator Author

@aagarwal1012 How do you suggest getting past the failing checks? This is ultimately a one line change.

Copy link
Owner

@aagarwal1012 aagarwal1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aagarwal1012
Copy link
Owner

@awhitford, this is failed due to codecov which we can ignore for now.

@aagarwal1012 aagarwal1012 merged commit 601083b into aagarwal1012:master Oct 12, 2020
@awhitford awhitford deleted the fade_timer branch October 12, 2020 06:20
@aagarwal1012 aagarwal1012 linked an issue Oct 14, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

timer not disposed when the animated text is
2 participants