Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the wrong documentation issue for the RotateAnimatedTextKit method #112

Merged
merged 1 commit into from
Oct 3, 2020
Merged

Fixed the wrong documentation issue for the RotateAnimatedTextKit method #112

merged 1 commit into from
Oct 3, 2020

Conversation

aniketambore
Copy link
Contributor

RotateAnimatedTextKit

So, I'm just trying animated_text_kit plugin.
While taking the Usage case of README.md into consideration.
Founded that for the Rotate text Usage example for the RotateAnimatedTextKit( ) method you implemented the alignment property as alignment: AlignmentDirectional.topStart which will disable the RotateAnimatedTextKit( ) behaviour, while giving the error as type '_MixedAlignment' is not a subtype of type 'Alignment'

Nothing more fancy, I just removed that error causing line from README.md :) .
Thankyou ✌.

@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #112 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #112   +/-   ##
=======================================
  Coverage   68.30%   68.30%           
=======================================
  Files           7        7           
  Lines         571      571           
=======================================
  Hits          390      390           
  Misses        181      181           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d8f4f...763e68b. Read the comment docs.

Copy link
Owner

@aagarwal1012 aagarwal1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aagarwal1012 aagarwal1012 merged commit 2a5354d into aagarwal1012:master Oct 3, 2020
@aagarwal1012
Copy link
Owner

@allcontributors add @aniketambore for updating docs.

@allcontributors
Copy link
Contributor

@aagarwal1012

I've put up a pull request to add @aniketambore! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants