Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TextAlign to TextLiquidFill #107

Merged
merged 2 commits into from
Sep 18, 2020
Merged

Add TextAlign to TextLiquidFill #107

merged 2 commits into from
Sep 18, 2020

Conversation

nakjemmy
Copy link
Contributor

Pull Request Process

  1. Ensure any install or build dependencies are removed before the end of the layer when doing a build.
  2. Update the README.md if needed with details of changes to the interface, this includes new environment variables, exposed ports, useful file locations and container parameters.
  3. Increase the version numbers in any examples files and the README.md to the new version that this Pull Request would represent. The versioning scheme we use is SemVer.
  4. You may merge the Pull Request in once you have the sign-off of one developer, or if you do not have permission to do that, you may request the second reviewer to merge it for you.

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #107 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   68.18%   68.30%   +0.11%     
==========================================
  Files           7        7              
  Lines         569      571       +2     
==========================================
+ Hits          388      390       +2     
  Misses        181      181              
Impacted Files Coverage Δ
lib/src/text_liquid_fill.dart 97.33% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0ed931...b91d535. Read the comment docs.

Copy link
Owner

@aagarwal1012 aagarwal1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aagarwal1012 aagarwal1012 merged commit e1d8f4f into aagarwal1012:master Sep 18, 2020
@aagarwal1012
Copy link
Owner

@allcontributors add @nakjemmy for the code enhancement.

@allcontributors
Copy link
Contributor

@aagarwal1012

I've put up a pull request to add @nakjemmy! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants