Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: calling containsKey on string #51

Closed
sgehrman opened this issue Jan 28, 2020 · 4 comments
Closed

Bug: calling containsKey on string #51

sgehrman opened this issue Jan 28, 2020 · 4 comments

Comments

@sgehrman
Copy link

Run the example app, enable break on all exceptions.

A bunch of places in the code call:
if (!widget.text[i].containsKey('text')) throw Error();

containsKey is not a function on String. Maybe you meant to use _texts?

@sgehrman
Copy link
Author

sgehrman commented Jan 28, 2020

Add strict linting and clean up your code with analyis_options.yaml file. You'll probably find lots of other errors.

https://pub.dev/packages/lint

@recapnrelax
Copy link

I'm also seeing this issue.

AadumKhor added a commit to AadumKhor/Animated-Text-Kit that referenced this issue May 24, 2020
AadumKhor added a commit to AadumKhor/Animated-Text-Kit that referenced this issue May 24, 2020
@AadumKhor AadumKhor mentioned this issue May 24, 2020
AadumKhor added a commit that referenced this issue May 25, 2020
@AadumKhor
Copy link
Collaborator

@sgehrman I have added a type check in #82 to ensure it is not called on a string. Please check and update if you see any other issue with it.

@aagarwal1012
Copy link
Owner

@sgehrman, we have pushed a new version named v2.2.0 of animated text kit that solves this issue. Please check and feel free to reopen it if any problem arises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants