We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This looks wrong:
Animated-Text-Kit/lib/src/text_liquid_fill.dart
Line 4 in d4c3346
Note that it is being set by _TextLiquidFillState.initState:
_TextLiquidFillState.initState
Lines 78 to 82 in d4c3346
I'm guessing that _textKey should be a member of the _TextLiquidFillState class. However, I suspect that this was moved to expose it WavePainter:
_textKey
_TextLiquidFillState
WavePainter
Lines 165 to 181 in d4c3346
However, it should simply be passed.
The concern/risk is that two instances of TextLiquidFill will collide/overwrite this global.
TextLiquidFill
The text was updated successfully, but these errors were encountered:
Revised _textKey to not be a global variable. Resolves aagarwal1012#129.
5571225
fce7109
No branches or pull requests
This looks wrong:
Animated-Text-Kit/lib/src/text_liquid_fill.dart
Line 4 in d4c3346
Note that it is being set by
_TextLiquidFillState.initState
:Animated-Text-Kit/lib/src/text_liquid_fill.dart
Lines 78 to 82 in d4c3346
I'm guessing that
_textKey
should be a member of the_TextLiquidFillState
class. However, I suspect that this was moved to expose itWavePainter
:Animated-Text-Kit/lib/src/text_liquid_fill.dart
Lines 165 to 181 in d4c3346
However, it should simply be passed.
The concern/risk is that two instances of
TextLiquidFill
will collide/overwrite this global.The text was updated successfully, but these errors were encountered: