Skip to content

Conversation

8ngine
Copy link

@8ngine 8ngine commented Jul 22, 2023

No description provided.

@8ngine
Copy link
Author

8ngine commented Jul 22, 2023

merging different types of smells

@MiniDigger
Copy link
Contributor

?
you only added unused code.
the utils seem nice, tinyprotocol is used as a one class copy paste thing tho, so if you indent on exposing this as new api it should prolly be inlined

@mr583372
Copy link

no, I had been removing code smells for a university assignment though I'm not great with Github / Gitlab yet so I clearly made several mistakes both in my work and the upload I'm sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants