Quick/support jsonc ext #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
wesleyboar
added a commit
to TACC/Core-CMS
that referenced
this pull request
Apr 21, 2021
The support required `tacc-wbomar/jsonc-require` repo. But Jenkins has credential failure if downloading from Git. Alt: My PR to aMarCruz/jsonc-require is approved and merged. Then the `.jsonc` support will be built into `json-require`. SEE: aMarCruz/jsonc-require#1
wesleyboar
added a commit
to TACC/Core-CMS
that referenced
this pull request
Apr 21, 2021
The support required `tacc-wbomar/jsonc-require` repo. But Jenkins has credential failure if downloading from Git. Alt: My PR to aMarCruz/jsonc-require is approved and merged. Then the `.jsonc` support will be built into `json-require`. SEE: aMarCruz/jsonc-require#1
|
@tacc-wbomar , simple but excellent contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Support
.jsoncextension. References:Changes
README.mdto suggest support.Background
After reading Using Comments in JSON with Node.js and JavaScript Examples, I chose to use JSON with comments, but with the
.jsoncextension (supported by Visual Studio Code). The.jsoncextension would let others—who are unaware of the availability ofjsonc-requirein a codebase—know that the file is not a regular JSON file (and hopefully lead them to see how it is imported elsewhere in the codebase).